Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plot duplication and purging logic #7939

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix plot duplication and purging logic #7939

wants to merge 2 commits into from

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Dec 2, 2024 •
edited
Loading

Closes #7926

Describe your changes:

  1. Duplicate data was not being properly eliminated due to outdated use of lodash utility uniq. Replaced that with the right .sortedUniqBy
  2. Faulty logic when records out of range are being purged. Fixed that logic to take into account in-place data modification.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.44%. Comparing base (ea9947c) to head (538216b).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7939      +/-   ##
==========================================
- Coverage   57.66%   57.44%   -0.23%     
==========================================
  Files         677      677              
  Lines       27373    27374       +1     
  Branches     2689     2689              
==========================================
- Hits        15786    15724      -62     
- Misses      11248    11309      +61     
- Partials      339      341       +2
Flag Coverage Δ
e2e-ci 62.41% <100.00%> (-0.07%) ⬇️
e2e-full 41.83% <80.00%> (-16.31%) ⬇️
unit 49.27% <60.00%> (-0.08%) ⬇️
Files with missing lines Coverage Δ
src/plugins/plot/MctPlot.vue 37.20% <ø> (ø)
src/plugins/plot/configuration/PlotSeries.js 87.24% <100.00%> (+0.57%) ⬆️
...gins/telemetryTable/TelemetryTableConfiguration.js 66.27% <100.00%> (ø)

... and 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9947c...538216b. Read the comment docs.

jvigliotta
jvigliotta approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

davetsay added a commit that referenced this pull request Dec 16, 2024
@davetsay
cherry pick ##7939
b25076e 
fix plot duplication and purge logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

@davetsay davetsay Awaiting requested review from davetsay

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Plots] Zooming out and in can cause the plot to display incorrectly
2 participants
@shefalijoshi @jvigliotta